From 7fb3d955967f3cd60fc5213e59bbfbc20af70266 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Wed, 27 Nov 2024 10:33:53 +0100 Subject: [PATCH] review & identified a cast that isn't handled, document that --- pageserver/src/page_service.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pageserver/src/page_service.rs b/pageserver/src/page_service.rs index 2a7ba8d97b..7d7679a68c 100644 --- a/pageserver/src/page_service.rs +++ b/pageserver/src/page_service.rs @@ -1136,6 +1136,9 @@ impl PageServerHandler { // - Case 2: If the Reading stage is waiting on its downstream (send to Batching), // it follows that Batching is waiting for Executor. // Executor will observe self.cancel when it sends the response, and exit with Err(QueryError::Shutdown). + // - Case 3: the Executor stage observes self.cancel and exits with Err() while the Reading + // stage is waiting for a message from the client. If no message from the client arrives, + // the Reading stage will never exit. // // In either case, a task exits, which makes the other tasks in the pipeline exit. //