From 84c5f681b07479b4d128d2e0e31d0a2d01f6b9fa Mon Sep 17 00:00:00 2001 From: Kirill Bulatov Date: Thu, 20 Oct 2022 13:44:03 +0300 Subject: [PATCH] Fix test feature detection (#2659) Follow-up of #2636 and #2654 , fixing the test detection feature. Pageserver currently outputs features as ``` /target/debug/pageserver --version Neon page server git:7734929a8202c8cc41596a861ffbe0b51b5f3cb9 failpoints: true, features: ["testing", "profiling"] ``` --- test_runner/fixtures/neon_fixtures.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test_runner/fixtures/neon_fixtures.py b/test_runner/fixtures/neon_fixtures.py index c6bfa7f69e..a77b3958c9 100644 --- a/test_runner/fixtures/neon_fixtures.py +++ b/test_runner/fixtures/neon_fixtures.py @@ -1665,11 +1665,11 @@ class NeonPageserver(PgProtocol): self.stop(immediate=True) def is_testing_enabled_or_skip(self): - if "testing:true" not in self.version: + if '"testing"' not in self.version: pytest.skip("pageserver was built without 'testing' feature") def is_profiling_enabled_or_skip(self): - if "profiling:true" not in self.version: + if '"profiling"' not in self.version: pytest.skip("pageserver was built without 'profiling' feature") def http_client(self, auth_token: Optional[str] = None) -> NeonPageserverHttpClient: