From 853552dcb4a09d52de79bcdd853112ce4a88f967 Mon Sep 17 00:00:00 2001 From: Em Sharnoff Date: Sun, 10 Sep 2023 10:15:53 -0700 Subject: [PATCH] vm-monitor: Don't include Args in top-level span (#5264) It makes the logs too verbose. ref https://neondb.slack.com/archives/C03F5SM1N02/p1694281232874719?thread_ts=1694272777.207109&cid=C03F5SM1N02 --- libs/vm_monitor/src/lib.rs | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libs/vm_monitor/src/lib.rs b/libs/vm_monitor/src/lib.rs index 2eee31c965..1cbfdc6ba6 100644 --- a/libs/vm_monitor/src/lib.rs +++ b/libs/vm_monitor/src/lib.rs @@ -178,14 +178,17 @@ pub async fn ws_handler( /// Starts the monitor. If startup fails or the monitor exits, an error will /// be logged and our internal state will be reset to allow for new connections. -#[tracing::instrument(skip_all, fields(?args))] +#[tracing::instrument(skip_all)] async fn start_monitor( ws: WebSocket, args: &Args, kill: broadcast::Receiver<()>, token: CancellationToken, ) { - info!("accepted new websocket connection -> starting monitor"); + info!( + ?args, + "accepted new websocket connection -> starting monitor" + ); let timeout = Duration::from_secs(4); let monitor = tokio::time::timeout( timeout,