From 8b10701a0f6f2826be4d4e4103a5cab1780e65c9 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Tue, 23 Apr 2024 13:58:21 +0000 Subject: [PATCH] perf!: use 64k insteadn of 8k buffers for blob_io and ephemeral_file --- pageserver/src/tenant/blob_io.rs | 2 +- pageserver/src/tenant/ephemeral_file/zero_padded_read_write.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pageserver/src/tenant/blob_io.rs b/pageserver/src/tenant/blob_io.rs index 0d33100ead..6e90b3e8ff 100644 --- a/pageserver/src/tenant/blob_io.rs +++ b/pageserver/src/tenant/blob_io.rs @@ -121,7 +121,7 @@ impl BlobWriter { self.offset } - const CAPACITY: usize = if BUFFERED { PAGE_SZ } else { 0 }; + const CAPACITY: usize = if BUFFERED { 64 * 1024 } else { 0 }; /// Writes the given buffer directly to the underlying `VirtualFile`. /// You need to make sure that the internal buffer is empty, otherwise diff --git a/pageserver/src/tenant/ephemeral_file/zero_padded_read_write.rs b/pageserver/src/tenant/ephemeral_file/zero_padded_read_write.rs index aa5a26e338..8b828142a4 100644 --- a/pageserver/src/tenant/ephemeral_file/zero_padded_read_write.rs +++ b/pageserver/src/tenant/ephemeral_file/zero_padded_read_write.rs @@ -41,7 +41,7 @@ pub enum ReadResult<'a> { } impl RW { - const TAIL_SZ: usize = PAGE_SZ; + const TAIL_SZ: usize = 64 * 1024; pub fn new(file: VirtualFile) -> Self { let bytes_flushed_tracker = owned_buffers_io::util::size_tracking_writer::Writer::new(file);