From 8d1bf152cf371130385065252389b1641f54edaf Mon Sep 17 00:00:00 2001 From: Eric Seppanen Date: Sun, 18 Apr 2021 22:56:55 -0700 Subject: [PATCH] fix up logged error for walreceiver connection failed For some reason printing the Result made the error string print twice, along with some annoying newlines. Extracting the error first gets the expected result (just one explanation, no newlines) --- pageserver/src/walreceiver.rs | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/pageserver/src/walreceiver.rs b/pageserver/src/walreceiver.rs index 8c869c7346..5ca5ffa199 100644 --- a/pageserver/src/walreceiver.rs +++ b/pageserver/src/walreceiver.rs @@ -34,14 +34,15 @@ pub fn thread_main(conf: &PageServerConf, wal_producer_connstr: &str) { runtime.block_on(async { loop { - let _res = walreceiver_main(conf, wal_producer_connstr).await; + let res = walreceiver_main(conf, wal_producer_connstr).await; - // TODO: print/log the error - info!( - "WAL streaming connection failed, retrying in 1 second...: {:?}", - _res - ); - sleep(Duration::from_secs(1)).await; + if let Err(e) = res { + info!( + "WAL streaming connection failed ({}), retrying in 1 second", + e + ); + sleep(Duration::from_secs(1)).await; + } } }); }