review: separate setting up otel tracing infra

pageserver/compaction/tests/tests.rs

@@ -10,7 +10,6 @@ pub(crate) fn setup_logging() {
         logging::init(
             logging::LogFormat::Test,
             logging::TracingErrorLayerEnablement::EnableWithRustLogFilter,
-            utils::logging::OtelEnablement::Disabled,
             logging::Output::Stdout,
         )
         .expect("Failed to init test logging");

pageserver/ctl/src/main.rs

@@ -117,7 +117,6 @@ async fn main() -> anyhow::Result<()> {
     logging::init(
         LogFormat::Plain,
         TracingErrorLayerEnablement::EnableWithRustLogFilter,
-        utils::logging::OtelEnablement::Disabled,
         logging::Output::Stdout,
     )?;
 

pageserver/pagebench/src/main.rs

@@ -35,7 +35,6 @@ fn main() {
     logging::init(
         logging::LogFormat::Plain,
         logging::TracingErrorLayerEnablement::Disabled,
-        utils::logging::OtelEnablement::Disabled,
         logging::Output::Stderr,
     )
     .unwrap();

pageserver/src/bin/pageserver.rs

@@ -114,7 +114,6 @@ fn main() -> anyhow::Result<()> {
     logging::init(
         conf.log_format,
         tracing_error_layer_enablement,
-        utils::logging::OtelEnablement::Disabled,
         logging::Output::Stdout,
     )?;
 

pageserver/src/tenant.rs

@@ -5718,7 +5718,6 @@ pub(crate) mod harness {
                 // enable it in case the tests exercise code paths that use
                 // debug_assert_current_span_has_tenant_and_timeline_id
                 logging::TracingErrorLayerEnablement::EnableWithRustLogFilter,
-                utils::logging::OtelEnablement::Disabled,
                 logging::Output::Stdout,
             )
             .expect("Failed to init test logging");