From 9222995c4f33498e31ae96ade58e81e131e9cf00 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Thu, 10 Apr 2025 11:16:35 +0200 Subject: [PATCH] REVIEW more the shutdown API --- pageserver/src/tenant/storage_layer/delta_layer.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pageserver/src/tenant/storage_layer/delta_layer.rs b/pageserver/src/tenant/storage_layer/delta_layer.rs index 23c237b030..ddb140b997 100644 --- a/pageserver/src/tenant/storage_layer/delta_layer.rs +++ b/pageserver/src/tenant/storage_layer/delta_layer.rs @@ -557,6 +557,9 @@ impl DeltaLayerWriterInner { let cap = buf.cap(); // pad zeros to the next io alignment requirement. + // TODO: this is actually padding to next PAGE_SZ multiple, but only if the buffer capacity is larger than that. + // We can't let the fact that we do direct IO, or the buffer capacity, dictate the on-disk format we write here. + // Need to find a better API that allows writing the format we intend to. let count = len.next_multiple_of(PAGE_SZ).min(cap) - len; buf.extend_with(0, count);