From 925f365aa01b30f8cc7964d55fd75bedfa5bda03 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Thu, 4 Jan 2024 13:15:48 +0000 Subject: [PATCH] review pass: found two incorrect Noops --- pageserver/src/walingest.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pageserver/src/walingest.rs b/pageserver/src/walingest.rs index bb1aec030b..13b64b4e33 100644 --- a/pageserver/src/walingest.rs +++ b/pageserver/src/walingest.rs @@ -383,8 +383,10 @@ impl WalIngest { if self.checkpoint.nextOid != next_oid { self.checkpoint.nextOid = next_oid; self.checkpoint_modified = true; + IngestRecordOutcome::Stored + } else { + IngestRecordOutcome::Noop } - IngestRecordOutcome::Noop // TODO review } else if info == pg_constants::XLOG_CHECKPOINT_ONLINE || info == pg_constants::XLOG_CHECKPOINT_SHUTDOWN { @@ -404,8 +406,10 @@ impl WalIngest { { self.checkpoint.oldestXid = xlog_checkpoint.oldestXid; self.checkpoint_modified = true; + IngestRecordOutcome::Stored + } else { + IngestRecordOutcome::Noop } - IngestRecordOutcome::Noop } else if info == pg_constants::XLOG_FPI || info == pg_constants::XLOG_FPI_FOR_HINT { // These records are importan for us, bu they are handled by