From 93b41cbb58d3a9430f184e0a1aacfc0f3fc0f3e0 Mon Sep 17 00:00:00 2001
From: Christian Schwarz <christian@neon.tech>
Date: Wed, 20 Sep 2023 17:55:58 +0200
Subject: [PATCH] page cache metrics: remove unused read_accesses_ephemeral &
 read_hits_ephemeral (#5338)

We removed the user of this in #4994 .

But the metrics field was `pub`, so, didn't cause an unused-warning in
#4994.

This is preliminary for: #5339
---
 pageserver/src/metrics.rs | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/pageserver/src/metrics.rs b/pageserver/src/metrics.rs
index 691ccafae1..6d1c89c3db 100644
--- a/pageserver/src/metrics.rs
+++ b/pageserver/src/metrics.rs
@@ -129,10 +129,8 @@ pub(crate) static MATERIALIZED_PAGE_CACHE_HIT: Lazy<IntCounter> = Lazy::new(|| {
 
 pub struct PageCacheMetrics {
     pub read_accesses_materialized_page: IntCounter,
-    pub read_accesses_ephemeral: IntCounter,
     pub read_accesses_immutable: IntCounter,
 
-    pub read_hits_ephemeral: IntCounter,
     pub read_hits_immutable: IntCounter,
     pub read_hits_materialized_page_exact: IntCounter,
     pub read_hits_materialized_page_older_lsn: IntCounter,
@@ -163,24 +161,12 @@ pub static PAGE_CACHE: Lazy<PageCacheMetrics> = Lazy::new(|| PageCacheMetrics {
             .unwrap()
     },
 
-    read_accesses_ephemeral: {
-        PAGE_CACHE_READ_ACCESSES
-            .get_metric_with_label_values(&["ephemeral"])
-            .unwrap()
-    },
-
     read_accesses_immutable: {
         PAGE_CACHE_READ_ACCESSES
             .get_metric_with_label_values(&["immutable"])
             .unwrap()
     },
 
-    read_hits_ephemeral: {
-        PAGE_CACHE_READ_HITS
-            .get_metric_with_label_values(&["ephemeral", "-"])
-            .unwrap()
-    },
-
     read_hits_immutable: {
         PAGE_CACHE_READ_HITS
             .get_metric_with_label_values(&["immutable", "-"])