From 93b59e65a2dcc6c03e01a389c4e86dee0086e48d Mon Sep 17 00:00:00 2001 From: Erik Grinaker Date: Thu, 27 Feb 2025 13:56:28 +0100 Subject: [PATCH] pageserver: remove stale comment (#11016) No longer true now that we eagerly notify the compaction loop. --- pageserver/src/tenant/timeline.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pageserver/src/tenant/timeline.rs b/pageserver/src/tenant/timeline.rs index 3164cdbdd2..662088fbde 100644 --- a/pageserver/src/tenant/timeline.rs +++ b/pageserver/src/tenant/timeline.rs @@ -4212,10 +4212,6 @@ impl Timeline { // Stall flushes to backpressure if compaction can't keep up. This is propagated up // to WAL ingestion by having ephemeral layer rolls wait for flushes. - // - // NB: the compaction loop only checks `compaction_threshold` every 20 seconds, so - // we can end up stalling before compaction even starts. Consider making it more - // responsive (e.g. via `watch_level0_deltas`). if let Some(stall_threshold) = self.get_l0_flush_stall_threshold() { if l0_count >= stall_threshold { warn!(