diff --git a/compute_tools/src/pg_helpers.rs b/compute_tools/src/pg_helpers.rs index 8b6dc04069..6a22b865fa 100644 --- a/compute_tools/src/pg_helpers.rs +++ b/compute_tools/src/pg_helpers.rs @@ -171,7 +171,7 @@ impl PgQuote for PgIdent { /// always quotes provided string with `""` and escapes every `"`. Not idempotent, /// i.e. if string is already escaped it will be escaped again. fn quote(&self) -> String { - let result = format!("\"{}\"", self.replace("\"", "\"\"")); + let result = format!("\"{}\"", self.replace('"', "\"\"")); result } } diff --git a/compute_tools/src/spec.rs b/compute_tools/src/spec.rs index 41e4174bf0..1dd7c0044e 100644 --- a/compute_tools/src/spec.rs +++ b/compute_tools/src/spec.rs @@ -215,7 +215,7 @@ pub fn handle_databases(spec: &ClusterSpec, client: &mut Client) -> Result<()> { if let Some(r) = pg_db { // XXX: db owner name is returned as quoted string from Postgres, // when quoting is needed. - let new_owner = if r.owner.starts_with('\"') { + let new_owner = if r.owner.starts_with('"') { db.owner.quote() } else { db.owner.clone() diff --git a/pageserver/src/layered_repository.rs b/pageserver/src/layered_repository.rs index 5dae1902c1..975b2f5d2b 100644 --- a/pageserver/src/layered_repository.rs +++ b/pageserver/src/layered_repository.rs @@ -893,12 +893,11 @@ impl Timeline for LayeredTimeline { let seg = SegmentTag { rel, segno: 0 }; - let result; - if let Some((layer, lsn)) = self.get_layer_for_read(seg, lsn)? { - result = layer.get_seg_exists(lsn)?; + let result = if let Some((layer, lsn)) = self.get_layer_for_read(seg, lsn)? { + layer.get_seg_exists(lsn)? } else { - result = false; - } + false + }; trace!("get_rel_exists: {} at {} -> {}", rel, lsn, result); Ok(result) diff --git a/pageserver/src/layered_repository/inmemory_layer.rs b/pageserver/src/layered_repository/inmemory_layer.rs index 17b061b20e..6e24bf6022 100644 --- a/pageserver/src/layered_repository/inmemory_layer.rs +++ b/pageserver/src/layered_repository/inmemory_layer.rs @@ -170,12 +170,11 @@ impl Layer for InMemoryLayer { fn filename(&self) -> PathBuf { let inner = self.inner.read().unwrap(); - let end_lsn; - if let Some(drop_lsn) = inner.end_lsn { - end_lsn = drop_lsn; + let end_lsn = if let Some(drop_lsn) = inner.end_lsn { + drop_lsn } else { - end_lsn = Lsn(u64::MAX); - } + Lsn(u64::MAX) + }; let delta_filename = DeltaFileName { seg: self.seg, diff --git a/pageserver/src/walrecord.rs b/pageserver/src/walrecord.rs index 378a015d4a..ca9107cdbf 100644 --- a/pageserver/src/walrecord.rs +++ b/pageserver/src/walrecord.rs @@ -268,12 +268,11 @@ impl XlXactParsedRecord { let info = xl_info & pg_constants::XLOG_XACT_OPMASK; // The record starts with time of commit/abort let xact_time = buf.get_i64_le(); - let xinfo; - if xl_info & pg_constants::XLOG_XACT_HAS_INFO != 0 { - xinfo = buf.get_u32_le(); + let xinfo = if xl_info & pg_constants::XLOG_XACT_HAS_INFO != 0 { + buf.get_u32_le() } else { - xinfo = 0; - } + 0 + }; let db_id; let ts_id; if xinfo & pg_constants::XACT_XINFO_HAS_DBINFO != 0 { @@ -502,7 +501,6 @@ pub fn decode_wal_record(record: Bytes) -> DecodedWALRecord { 0..=pg_constants::XLR_MAX_BLOCK_ID => { /* XLogRecordBlockHeader */ let mut blk = DecodedBkpBlock::new(); - let fork_flags: u8; if block_id <= max_block_id { // TODO @@ -515,7 +513,7 @@ pub fn decode_wal_record(record: Bytes) -> DecodedWALRecord { } max_block_id = block_id; - fork_flags = buf.get_u8(); + let fork_flags: u8 = buf.get_u8(); blk.forknum = fork_flags & pg_constants::BKPBLOCK_FORK_MASK; blk.flags = fork_flags; blk.has_image = (fork_flags & pg_constants::BKPBLOCK_HAS_IMAGE) != 0; diff --git a/proxy/src/main.rs b/proxy/src/main.rs index fb3bf725b8..de618ccde9 100644 --- a/proxy/src/main.rs +++ b/proxy/src/main.rs @@ -122,7 +122,7 @@ async fn main() -> anyhow::Result<()> { None => RouterConfig::Dynamic(auth_method), Some(addr) => { if let ClientAuthMethod::Password = auth_method { - let (host, port) = addr.split_once(":").unwrap(); + let (host, port) = addr.split_once(':').unwrap(); RouterConfig::Static { host: host.to_string(), port: port.parse().unwrap(),