From 9bf7664049c63f7d8e087f11eebe45006beb75ba Mon Sep 17 00:00:00 2001 From: Em Sharnoff Date: Mon, 8 Jan 2024 21:12:39 -0800 Subject: [PATCH] vm-monitor: Remove spammy log line (#6284) During a previous incident, we noticed that this particular line can be repeatedly logged every 100ms if the memory usage continues is persistently high enough to warrant upscaling. Per the added comment: Ideally we'd still like to include this log line, because it's useful information, but the simple way to include it produces far too many log lines, and the more complex ways to deduplicate the log lines while still including the information are probably not worth the effort right now. --- libs/vm_monitor/src/runner.rs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/libs/vm_monitor/src/runner.rs b/libs/vm_monitor/src/runner.rs index f162f53d24..ba37966476 100644 --- a/libs/vm_monitor/src/runner.rs +++ b/libs/vm_monitor/src/runner.rs @@ -446,12 +446,11 @@ impl Runner { if let Some(t) = self.last_upscale_request_at { let elapsed = t.elapsed(); if elapsed < Duration::from_secs(1) { - info!( - elapsed_millis = elapsed.as_millis(), - avg_non_reclaimable = bytes_to_mebibytes(cgroup_mem_stat.avg_non_reclaimable), - threshold = bytes_to_mebibytes(cgroup.threshold), - "cgroup memory stats are high enough to upscale but too soon to forward the request, ignoring", - ); + // *Ideally* we'd like to log here that we're ignoring the fact the + // memory stats are too high, but in practice this can result in + // spamming the logs with repetitive messages about ignoring the signal + // + // See https://github.com/neondatabase/neon/issues/5865 for more. continue; } }