From 9c8c55e8191fed0c07efebc01cff286d58e6c32d Mon Sep 17 00:00:00 2001 From: arpad-m Date: Mon, 3 Jul 2023 19:34:07 +0200 Subject: [PATCH] Add _cached and _bytes to pageserver_tenant_synthetic_size metric name (#4616) This renames the `pageserver_tenant_synthetic_size` metric to `pageserver_tenant_synthetic_cached_size_bytes`, as was requested on slack (link in the linked issue). * `_cached` to hint that it is not incrementally calculated * `_bytes` to indicate the unit the size is measured in Fixes #3748 --- pageserver/src/metrics.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pageserver/src/metrics.rs b/pageserver/src/metrics.rs index 00745143bd..8765aa6aff 100644 --- a/pageserver/src/metrics.rs +++ b/pageserver/src/metrics.rs @@ -204,11 +204,11 @@ pub static TENANT_STATE_METRIC: Lazy = Lazy::new(|| { pub static TENANT_SYNTHETIC_SIZE_METRIC: Lazy = Lazy::new(|| { register_uint_gauge_vec!( - "pageserver_tenant_synthetic_size", - "Synthetic size of each tenant", + "pageserver_tenant_synthetic_cached_size_bytes", + "Synthetic size of each tenant in bytes", &["tenant_id"] ) - .expect("Failed to register pageserver_tenant_synthetic_size metric") + .expect("Failed to register pageserver_tenant_synthetic_cached_size_bytes metric") }); // Metrics for cloud upload. These metrics reflect data uploaded to cloud storage,