From a4b3e3f9a471376f4b1637fbb214e2dd8114822a Mon Sep 17 00:00:00 2001
From: Christian Schwarz <christian@neon.tech>
Date: Mon, 30 Jun 2025 14:11:15 +0200
Subject: [PATCH] bring back special comment on CompactionError::Offload

---
 pageserver/src/tenant.rs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/pageserver/src/tenant.rs b/pageserver/src/tenant.rs
index cb5046b20f..dd3a6beb3b 100644
--- a/pageserver/src/tenant.rs
+++ b/pageserver/src/tenant.rs
@@ -3319,6 +3319,8 @@ impl TenantShard {
         }
         match err {
             CompactionError::ShuttingDown => unreachable!("is_cancel"),
+            // Offload failures don't trip the circuit breaker, since they're cheap to retry and
+            // shouldn't block compaction.
             CompactionError::Offload(_) => {}
             CompactionError::CollectKeySpaceError(err) => {
                 // CollectKeySpaceError::Cancelled and PageRead::Cancelled are handled in `err.is_cancel` branch.