rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-06-01 04:20:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

pageserver: shutdown timeline metrics during delete

Browse Source
This commit is contained in:
John Spray
2024-03-25 09:45:52 +00:00
parent d5e2fc4dfc
commit a7e8e4b449
2 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
test_runner/regress/test_timeline_delete.py
View File

@@ -88,6 +88,14 @@ def test_timeline_delete(neon_simple_env: NeonEnv):
timeline_path = env.pageserver.timeline_dir(env.initial_tenant, leaf_timeline_id)
assert timeline_path.exists()
# Before deleting, timeline metrics should be present
assert (
ps_http.get_metric_value(
"pageserver_current_logical_size", {"timeline_id": str(leaf_timeline_id)}
)
is not None
)
# retry deletes when compaction or gc is running in pageserver
# TODO: review whether this wait_until is actually necessary, we do an await() internally
wait_until(
@@ -106,6 +114,14 @@ def test_timeline_delete(neon_simple_env: NeonEnv):
ps_http.timeline_detail(env.initial_tenant, leaf_timeline_id)
assert exc.value.status_code == 404
# Check metrics were cleaned up
assert (
ps_http.get_metric_value(
"pageserver_current_logical_size", {"timeline_id": str(leaf_timeline_id)}
)
is None
)
wait_until(
number_of_iterations=3,
interval=0.2,