diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml index 41f9f51e86..aa1e152fb2 100644 --- a/.github/workflows/testing.yml +++ b/.github/workflows/testing.yml @@ -12,7 +12,7 @@ jobs: matrix: # If we want to duplicate this job for different # Rust toolchains (e.g. nightly or 1.37.0), add them here. - rust_toolchain: [stable] + rust_toolchain: [1.58] os: [ubuntu-latest, macos-latest] timeout-minutes: 30 name: run regression test suite @@ -87,7 +87,7 @@ jobs: ~/.cargo/registry ~/.cargo/git target - key: ${{ runner.os }}-cargo-${{ hashFiles('./Cargo.lock') }} + key: ${{ runner.os }}-cargo-${{ hashFiles('./Cargo.lock') }}-rust-${{ matrix.rust_toolchain }} - name: Run cargo clippy run: ./run_clippy.sh diff --git a/pageserver/src/walreceiver.rs b/pageserver/src/walreceiver.rs index df8dd2fc29..e54406a450 100644 --- a/pageserver/src/walreceiver.rs +++ b/pageserver/src/walreceiver.rs @@ -469,12 +469,9 @@ async fn timeline_wal_broker_loop_step( updates = broker_subscription.fetch_data() => match updates { Some(mut all_timeline_updates) => { if let Some(subscribed_timeline_updates) = all_timeline_updates.remove(&id) { - match wal_connection_manager.select_connection_candidate(subscribed_timeline_updates) { - Some(candidate) => { - info!("Switching to different safekeeper {} for timeline {id}, reason: {:?}", candidate.safekeeper_id, candidate.reason); - wal_connection_manager.change_connection(candidate.safekeeper_id, candidate.wal_producer_connstr).await; - }, - None => {} + if let Some(candidate) = wal_connection_manager.select_connection_candidate(subscribed_timeline_updates) { + info!("Switching to different safekeeper {} for timeline {id}, reason: {:?}", candidate.safekeeper_id, candidate.reason); + wal_connection_manager.change_connection(candidate.safekeeper_id, candidate.wal_producer_connstr).await; } } },