From abb07df028176c1cdf3c9e1a384f59a014d186e6 Mon Sep 17 00:00:00 2001 From: Bojan Serafimov Date: Fri, 9 Sep 2022 00:46:13 -0400 Subject: [PATCH] Plan request tracing implementation --- pageserver/src/page_service.rs | 3 +++ pageserver/src/tenant_config.rs | 1 + 2 files changed, 4 insertions(+) diff --git a/pageserver/src/page_service.rs b/pageserver/src/page_service.rs index 783fcb2412..c151bacaa3 100644 --- a/pageserver/src/page_service.rs +++ b/pageserver/src/page_service.rs @@ -472,6 +472,7 @@ impl PageServerHandler { let tenant_id = tenant_id.to_string(); let timeline_id = timeline_id.to_string(); + // TODO(now) append to trace if tenant is configured for read tracing let response = match zenith_fe_msg { PagestreamFeMessage::Exists(req) => SMGR_QUERY_TIME .with_label_values(&["get_rel_exists", &tenant_id, &timeline_id]) @@ -854,6 +855,8 @@ impl postgres_backend::Handler for PageServerHandler { self.check_permission(Some(tenantid))?; + // TODO(now) make trace logger if tenant is configured for read tracing. + // Also flush trace logger on drop. self.handle_pagerequests(pgb, timelineid, tenantid)?; } else if query_string.starts_with("basebackup ") { let (_, params_raw) = query_string.split_at("basebackup ".len()); diff --git a/pageserver/src/tenant_config.rs b/pageserver/src/tenant_config.rs index 73bf3636d2..7a2914c844 100644 --- a/pageserver/src/tenant_config.rs +++ b/pageserver/src/tenant_config.rs @@ -87,6 +87,7 @@ pub struct TenantConf { /// A lagging safekeeper will be changed after `lagging_wal_timeout` time elapses since the last WAL update, /// to avoid eager reconnects. pub max_lsn_wal_lag: NonZeroU64, + // TODO(now) add setting to enable read request tracing } /// Same as TenantConf, but this struct preserves the information about