diff --git a/pageserver/src/walredo.rs b/pageserver/src/walredo.rs index fbb1984859..d1c2b9ae5a 100644 --- a/pageserver/src/walredo.rs +++ b/pageserver/src/walredo.rs @@ -22,7 +22,7 @@ use byteorder::{ByteOrder, LittleEndian}; use bytes::{Buf, BufMut, Bytes, BytesMut}; use lazy_static::lazy_static; use log::*; -use serde::{Deserialize, Serialize}; +use serde::Serialize; use std::fs; use std::fs::OpenOptions; use std::io::prelude::*; @@ -59,7 +59,7 @@ use postgres_ffi::XLogRecord; /// In Postgres `BufferTag` structure is used for exactly the same purpose. /// [See more related comments here](https://github.com/postgres/postgres/blob/99c5852e20a0987eca1c38ba0c09329d4076b6a0/src/include/storage/buf_internals.h#L91). /// -#[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Clone, Copy, Serialize, Deserialize)] +#[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Clone, Copy, Serialize)] pub struct BufferTag { pub rel: RelTag, pub blknum: u32, diff --git a/proxy/src/mgmt.rs b/proxy/src/mgmt.rs index 0d3c114421..90fccd770d 100644 --- a/proxy/src/mgmt.rs +++ b/proxy/src/mgmt.rs @@ -5,7 +5,7 @@ use std::{ use anyhow::bail; use bytes::Bytes; -use serde::{Deserialize, Serialize}; +use serde::Deserialize; use zenith_utils::{ postgres_backend::{self, query_from_cstring, AuthType, PostgresBackend}, pq_proto::{BeMessage, SINGLE_COL_ROWDESC}, @@ -60,13 +60,13 @@ struct MgmtHandler { // "Failure": "oops" // } // } -#[derive(Serialize, Deserialize)] +#[derive(Deserialize)] pub struct PsqlSessionResponse { session_id: String, result: PsqlSessionResult, } -#[derive(Serialize, Deserialize)] +#[derive(Deserialize)] pub enum PsqlSessionResult { Success(DatabaseInfo), Failure(String), diff --git a/walkeeper/src/safekeeper.rs b/walkeeper/src/safekeeper.rs index bffc329278..bbcc2649db 100644 --- a/walkeeper/src/safekeeper.rs +++ b/walkeeper/src/safekeeper.rs @@ -111,7 +111,7 @@ impl Default for SafeKeeperState { // protocol messages /// Initial Proposer -> Acceptor message -#[derive(Debug, Serialize, Deserialize)] +#[derive(Debug, Deserialize)] pub struct ProposerGreeting { /// proposer-acceptor protocol version pub protocol_version: u32, @@ -128,19 +128,19 @@ pub struct ProposerGreeting { /// Acceptor -> Proposer initial response: the highest term known to me /// (acceptor voted for). -#[derive(Debug, Serialize, Deserialize)] +#[derive(Debug, Serialize)] pub struct AcceptorGreeting { term: u64, } /// Vote request sent from proposer to safekeepers -#[derive(Debug, Serialize, Deserialize)] +#[derive(Debug, Deserialize)] pub struct VoteRequest { term: Term, } /// Vote itself, sent from safekeeper to proposer -#[derive(Debug, Serialize, Deserialize)] +#[derive(Debug, Serialize)] pub struct VoteResponse { term: Term, // not really needed, just a sanity check vote_given: u64, // fixme u64 due to padding @@ -152,12 +152,12 @@ pub struct VoteResponse { /// Request with WAL message sent from proposer to safekeeper. Along the way it /// announces 1) successful election (with epoch_start_lsn); 2) commit_lsn. -#[derive(Debug, Serialize, Deserialize)] +#[derive(Debug)] pub struct AppendRequest { pub h: AppendRequestHeader, pub wal_data: Bytes, } -#[derive(Debug, Clone, Serialize, Deserialize)] +#[derive(Debug, Clone, Deserialize)] pub struct AppendRequestHeader { pub term: Term, // LSN since the proposer appends WAL; determines epoch switch point. diff --git a/zenith_utils/tests/bin_ser_test.rs b/zenith_utils/tests/bin_ser_test.rs index d920b430f3..ada43a1189 100644 --- a/zenith_utils/tests/bin_ser_test.rs +++ b/zenith_utils/tests/bin_ser_test.rs @@ -1,10 +1,10 @@ use bytes::{Buf, BytesMut}; use hex_literal::hex; -use serde::{Deserialize, Serialize}; +use serde::Deserialize; use std::io::Read; use zenith_utils::bin_ser::LeSer; -#[derive(Debug, PartialEq, Serialize, Deserialize)] +#[derive(Debug, PartialEq, Deserialize)] pub struct HeaderData { magic: u16, info: u16,