diff --git a/compute_tools/src/extension_server.rs b/compute_tools/src/extension_server.rs index 64c338f4d7..00f46386e7 100644 --- a/compute_tools/src/extension_server.rs +++ b/compute_tools/src/extension_server.rs @@ -258,14 +258,11 @@ pub fn create_control_files(remote_extensions: &RemoteExtSpec, pgbin: &str) { async fn download_extension_tar(ext_remote_storage: &str, ext_path: &str) -> Result { let uri = format!("{}/{}", ext_remote_storage, ext_path); - info!("Download extension {:?} from uri {:?}", ext_path, uri); + info!("Download extension {} from uri {}", ext_path, uri); match do_extension_server_request(&uri).await { Ok(resp) => { - info!( - "Successfully downloaded remote extension data {:?}", - ext_path - ); + info!("Successfully downloaded remote extension data {}", ext_path); REMOTE_EXT_REQUESTS_TOTAL .with_label_values(&[&StatusCode::OK.to_string()]) .inc(); @@ -285,7 +282,10 @@ async fn download_extension_tar(ext_remote_storage: &str, ext_path: &str) -> Res async fn do_extension_server_request(uri: &str) -> Result { let resp = reqwest::get(uri).await.map_err(|e| { ( - format!("could not perform remote extensions server request: {}", e), + format!( + "could not perform remote extensions server request: {:?}", + e + ), UNKNOWN_HTTP_STATUS.to_string(), ) })?; @@ -295,7 +295,7 @@ async fn do_extension_server_request(uri: &str) -> Result match resp.bytes().await { Ok(resp) => Ok(resp), Err(e) => Err(( - format!("could not read remote extensions server response: {}", e), + format!("could not read remote extensions server response: {:?}", e), // It's fine to return and report error with status as 200 OK, // because we still failed to read the response. status.to_string(), diff --git a/compute_tools/src/migration.rs b/compute_tools/src/migration.rs index aa3c6b01f0..7b7b042d84 100644 --- a/compute_tools/src/migration.rs +++ b/compute_tools/src/migration.rs @@ -125,7 +125,7 @@ impl<'m> MigrationRunner<'m> { info!("Finished migration id={}", migration_id); } Err(e) => { - error!("Failed to run migration id={}: {}", migration_id, e); + error!("Failed to run migration id={}: {:?}", migration_id, e); DB_MIGRATION_FAILED .with_label_values(&[migration_id.to_string().as_str()]) .inc(); diff --git a/compute_tools/src/spec.rs b/compute_tools/src/spec.rs index 43a820885b..37d5d3a1a6 100644 --- a/compute_tools/src/spec.rs +++ b/compute_tools/src/spec.rs @@ -28,7 +28,7 @@ fn do_control_plane_request( .map_err(|e| { ( true, - format!("could not perform spec request to control plane: {}", e), + format!("could not perform spec request to control plane: {:?}", e), UNKNOWN_HTTP_STATUS.to_string(), ) })?; @@ -39,7 +39,7 @@ fn do_control_plane_request( Ok(spec_resp) => Ok(spec_resp), Err(e) => Err(( true, - format!("could not deserialize control plane response: {}", e), + format!("could not deserialize control plane response: {:?}", e), status.to_string(), )), },