diff --git a/safekeeper/src/safekeeper.rs b/safekeeper/src/safekeeper.rs index 45e19c31b6..04c0fc2069 100644 --- a/safekeeper/src/safekeeper.rs +++ b/safekeeper/src/safekeeper.rs @@ -858,7 +858,7 @@ where /// /// Note: it is assumed that 'WAL we have is from the right term' check has /// already been done outside. - async fn update_commit_lsn(&mut self, mut candidate: Lsn) -> Result<()> { + async fn update_commit_lsn(&mut self, mut candidate: Lsn) -> Result<()> { // updates to inmem.commit_lsn go through here // Both peers and walproposer communicate this value, we might already // have a fresher (higher) version. candidate = max(candidate, self.state.inmem.commit_lsn); diff --git a/safekeeper/src/send_wal.rs b/safekeeper/src/send_wal.rs index 4a4a74a0fd..723519748b 100644 --- a/safekeeper/src/send_wal.rs +++ b/safekeeper/src/send_wal.rs @@ -468,7 +468,7 @@ impl SafekeeperPostgresHandler { &mut self, pgb: &mut PostgresBackend, start_pos: Lsn, - term: Option, + term: Option, // none for pageserver tli: WalResidentTimeline, ) -> Result<(), CopyStreamHandlerEnd> { let appname = self.appname.clone(); diff --git a/safekeeper/src/state.rs b/safekeeper/src/state.rs index 4d566b12a0..ac7333e04b 100644 --- a/safekeeper/src/state.rs +++ b/safekeeper/src/state.rs @@ -227,7 +227,7 @@ where } // keep in memory values up to date - self.inmem.commit_lsn = s.commit_lsn; + self.inmem.commit_lsn = s.commit_lsn; // and here? self.inmem.backup_lsn = s.backup_lsn; self.inmem.peer_horizon_lsn = s.peer_horizon_lsn; self.inmem.remote_consistent_lsn = s.remote_consistent_lsn; diff --git a/safekeeper/src/timeline.rs b/safekeeper/src/timeline.rs index 5eb0bd7146..008eab5623 100644 --- a/safekeeper/src/timeline.rs +++ b/safekeeper/src/timeline.rs @@ -124,6 +124,7 @@ impl Drop for WriteGuardSharedState<'_> { } }); + // this here wakes `send_wal` let _ = self.tli.commit_lsn_watch_tx.send_if_modified(|old| { if *old != commit_lsn { *old = commit_lsn;