From c8094ee51e4cf99e5dbc7f0f036fab335b999ff2 Mon Sep 17 00:00:00 2001 From: Alexander Bayandin Date: Thu, 17 Aug 2023 11:46:00 +0100 Subject: [PATCH] test_compatibility: run amcheck unconditionally (#4985) ## Problem The previous version of neon (that we use in the forward compatibility test) has installed `amcheck` extension now. We can run `pg_amcheck` unconditionally. ## Summary of changes - Run `pg_amcheck` in compatibility tests unconditionally --- test_runner/regress/test_compatibility.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/test_runner/regress/test_compatibility.py b/test_runner/regress/test_compatibility.py index fa386ee75a..6979b99708 100644 --- a/test_runner/regress/test_compatibility.py +++ b/test_runner/regress/test_compatibility.py @@ -394,13 +394,7 @@ def check_neon_works( test_output_dir / "dump-from-wal.filediff", ) - # TODO: Run pg_amcheck unconditionally after the next release - try: - pg_bin.run(["psql", connstr, "--command", "CREATE EXTENSION IF NOT EXISTS amcheck"]) - except subprocess.CalledProcessError: - log.info("Extension amcheck is not available, skipping pg_amcheck") - else: - pg_bin.run_capture(["pg_amcheck", connstr, "--install-missing", "--verbose"]) + pg_bin.run_capture(["pg_amcheck", connstr, "--install-missing", "--verbose"]) # Check that we can interract with the data pg_bin.run_capture(["pgbench", "--time=10", "--progress=2", connstr])