mirror of
https://github.com/neondatabase/neon.git
synced 2026-01-06 21:12:55 +00:00
CI(benchmarks): upload perf results for passed tests (#11649)
## Problem We run benchmarks in batches (five parallel jobs on different runners). If any test in a batch fails, we won’t upload any results for that batch, even for the tests that passed. ## Summary of changes - Move the results upload to a separate step in the run-python-test-set action, and execute this step even if tests fail.
This commit is contained in:
committed by
GitHub
parent
5df4a747e6
commit
cd2e1fbc7c
12
.github/actions/run-python-test-set/action.yml
vendored
12
.github/actions/run-python-test-set/action.yml
vendored
@@ -133,6 +133,7 @@ runs:
|
|||||||
fi
|
fi
|
||||||
|
|
||||||
PERF_REPORT_DIR="$(realpath test_runner/perf-report-local)"
|
PERF_REPORT_DIR="$(realpath test_runner/perf-report-local)"
|
||||||
|
echo "PERF_REPORT_DIR=${PERF_REPORT_DIR}" >> ${GITHUB_ENV}
|
||||||
rm -rf $PERF_REPORT_DIR
|
rm -rf $PERF_REPORT_DIR
|
||||||
|
|
||||||
TEST_SELECTION="test_runner/${{ inputs.test_selection }}"
|
TEST_SELECTION="test_runner/${{ inputs.test_selection }}"
|
||||||
@@ -209,11 +210,12 @@ runs:
|
|||||||
--verbose \
|
--verbose \
|
||||||
-rA $TEST_SELECTION $EXTRA_PARAMS
|
-rA $TEST_SELECTION $EXTRA_PARAMS
|
||||||
|
|
||||||
if [[ "${{ inputs.save_perf_report }}" == "true" ]]; then
|
- name: Upload performance report
|
||||||
export REPORT_FROM="$PERF_REPORT_DIR"
|
if: ${{ !cancelled() && inputs.save_perf_report == 'true' }}
|
||||||
export REPORT_TO="$PLATFORM"
|
shell: bash -euxo pipefail {0}
|
||||||
scripts/generate_and_push_perf_report.sh
|
run: |
|
||||||
fi
|
export REPORT_FROM="${PERF_REPORT_DIR}"
|
||||||
|
scripts/generate_and_push_perf_report.sh
|
||||||
|
|
||||||
- name: Upload compatibility snapshot
|
- name: Upload compatibility snapshot
|
||||||
# Note, that we use `github.base_ref` which is a target branch for a PR
|
# Note, that we use `github.base_ref` which is a target branch for a PR
|
||||||
|
|||||||
Reference in New Issue
Block a user