rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2025-12-26 07:39:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

clippy-deny the todo!() macro (#4340)

Browse Source 
`todo!()` shouldn't slip into prod code
This commit is contained in:
Christian Schwarz
2024-06-25 20:03:27 +02:00
committed by GitHub
parent 07f21dd6b6
commit cd9a550d97
3 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
.neon_clippy_args
View File

@@ -1,4 +1,5 @@
# * `-A unknown_lints` – do not warn about unknown lint suppressions # * `-A unknown_lints` – do not warn about unknown lint suppressions
# that people with newer toolchains might use # that people with newer toolchains might use
# * `-D warnings` - fail on any warnings (`cargo` returns non-zero exit status) # * `-D warnings` - fail on any warnings (`cargo` returns non-zero exit status)
export CLIPPY_COMMON_ARGS="--locked --workspace --all-targets -- -A unknown_lints -D warnings" # * `-D clippy::todo` - don't let `todo!()` slip into `main`
export CLIPPY_COMMON_ARGS="--locked --workspace --all-targets -- -A unknown_lints -D warnings -D clippy::todo"

2
libs/walproposer/src/walproposer.rs
View File

@@ -1,3 +1,5 @@
#![allow(clippy::todo)]
use std::ffi::CString; use std::ffi::CString;
use crate::{ use crate::{

8
trace/src/main.rs
View File

@@ -38,12 +38,6 @@ enum Command {
/// Print stats and anomalies about the traces /// Print stats and anomalies about the traces
Analyze, Analyze,
/// Draw the traces in svg format
Draw,
/// Send the read requests to a pageserver
Replay,
} }
// HACK This function will change and improve as we see what kind of analysis is useful. // HACK This function will change and improve as we see what kind of analysis is useful.
@@ -167,8 +161,6 @@ fn main() -> anyhow::Result<()> {
analyze_trace(reader); analyze_trace(reader);
} }
} }
Command::Draw => todo!(),
Command::Replay => todo!(),
} }
Ok(()) Ok(())