From ce45fd4cc72b5873179223ccbfc2b2be8ad2ca14 Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Wed, 27 Sep 2023 14:00:49 +0300 Subject: [PATCH] test_pageserver_metric_collection: allowed synthetic size to be cancelled at shutdown (#5398) [evidence] of these messages during shutdown. They can happen if we are unlucky enough. [evidence]: https://neon-github-public-dev.s3.amazonaws.com/reports/main/6323709725/index.html#suites/e557ea0d920cfebd45c1921296031273/4120269a64eed172 --- .../test_pageserver_metric_collection.py | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/test_runner/regress/test_pageserver_metric_collection.py b/test_runner/regress/test_pageserver_metric_collection.py index dae39d2752..74e016a9df 100644 --- a/test_runner/regress/test_pageserver_metric_collection.py +++ b/test_runner/regress/test_pageserver_metric_collection.py @@ -18,6 +18,9 @@ from werkzeug.wrappers.request import Request from werkzeug.wrappers.response import Response +# TODO: collect all of the env setup *AFTER* removal of RemoteStorageKind.NOOP + + @pytest.mark.parametrize( "remote_storage_kind", [RemoteStorageKind.NOOP, RemoteStorageKind.LOCAL_FS] ) @@ -68,6 +71,14 @@ def test_metric_collection( env = neon_env_builder.init_start(initial_tenant_conf={"pitr_interval": "0 sec"}) # httpserver is shut down before pageserver during passing run env.pageserver.allowed_errors.append(".*metrics endpoint refused the sent metrics*") + # we have a fast rate of calculation, these can happen at shutdown + env.pageserver.allowed_errors.append( + ".*synthetic_size_worker:calculate_synthetic_size.*:gather_size_inputs.*: failed to calculate logical size at .*: cancelled.*" + ) + env.pageserver.allowed_errors.append( + ".*synthetic_size_worker: failed to calculate synthetic size for tenant .*: failed to calculate some logical_sizes" + ) + tenant_id = env.initial_tenant timeline_id = env.initial_timeline endpoint = env.endpoints.create_start("main", tenant_id=tenant_id) @@ -211,6 +222,14 @@ def test_metric_collection_cleans_up_tempfile( # httpserver is shut down before pageserver during passing run env.pageserver.allowed_errors.append(".*metrics endpoint refused the sent metrics*") + # we have a fast rate of calculation, these can happen at shutdown + env.pageserver.allowed_errors.append( + ".*synthetic_size_worker:calculate_synthetic_size.*:gather_size_inputs.*: failed to calculate logical size at .*: cancelled.*" + ) + env.pageserver.allowed_errors.append( + ".*synthetic_size_worker: failed to calculate synthetic size for tenant .*: failed to calculate some logical_sizes" + ) + tenant_id = env.initial_tenant timeline_id = env.initial_timeline endpoint = env.endpoints.create_start("main", tenant_id=tenant_id)