From ce782f2fa6448d3ed2002e6fd51038f8a587bb30 Mon Sep 17 00:00:00 2001 From: John Spray Date: Tue, 24 Oct 2023 10:56:12 +0100 Subject: [PATCH] Upgrade an info! to an error! for a critical issue. --- pageserver/src/tenant/remote_timeline_client.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pageserver/src/tenant/remote_timeline_client.rs b/pageserver/src/tenant/remote_timeline_client.rs index 06e2292156..1a3ec1b4c6 100644 --- a/pageserver/src/tenant/remote_timeline_client.rs +++ b/pageserver/src/tenant/remote_timeline_client.rs @@ -691,11 +691,9 @@ impl RemoteTimelineClient { upload_queue.latest_files_changes_since_metadata_upload_scheduled += 1; Some((name, meta.generation)) } else { - // This can only happen if we forgot to to schedule the file upload - // before scheduling the delete. Log it because it is a rare/strange - // situation, and in case something is misbehaving, we'd like to know which - // layers experienced this. - info!( + // This should never happen: callers should ensure that any layer they + // request deletion of has already been scheduled for upload + error!( "Deleting layer {name} not found in latest_files list, never uploaded?" ); None