From d4d0aa6ed6c9f0408723c923df01f7718d42b1b0 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Mon, 2 Jan 2023 18:44:51 +0100 Subject: [PATCH] gc_iteration_internal: better log message & debug log level if nothing to do fixes https://github.com/neondatabase/neon/issues/3107 --- pageserver/src/tenant.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pageserver/src/tenant.rs b/pageserver/src/tenant.rs index 71cdc6cf1c..d74f263f08 100644 --- a/pageserver/src/tenant.rs +++ b/pageserver/src/tenant.rs @@ -1874,7 +1874,12 @@ impl Tenant { utils::failpoint_sleep_millis_async!("gc_iteration_internal_after_getting_gc_timelines"); - info!("starting on {} timelines", gc_timelines.len()); + // If there is nothing to GC, we don't want any messages in the INFO log. + if !gc_timelines.is_empty() { + info!("{} timelines need GC", gc_timelines.len()); + } else { + debug!("{} timelines need GC", gc_timelines.len()); + } // Perform GC for each timeline. //