From d99ace36016019941c34f7d4d5d99100629da8a0 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Thu, 2 Feb 2023 13:30:22 +0100 Subject: [PATCH] thanks to HistoryBuf, we can now derive Default for LayerAccessStatsInner --- pageserver/src/tenant/storage_layer.rs | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/pageserver/src/tenant/storage_layer.rs b/pageserver/src/tenant/storage_layer.rs index ea2bd9e328..c244c2c96a 100644 --- a/pageserver/src/tenant/storage_layer.rs +++ b/pageserver/src/tenant/storage_layer.rs @@ -91,7 +91,7 @@ pub enum ValueReconstructResult { #[derive(Debug)] pub struct LayerAccessStats(Mutex); -#[derive(Debug, Clone)] +#[derive(Debug, Default, Clone)] struct LayerAccessStatsInner { first_access: Option, count_by_access_kind: EnumMap, @@ -196,18 +196,6 @@ impl LayerResidenceStatus { pub static LAYER_ACCESS_STATS_KILLSWITCH: AtomicBool = AtomicBool::new(false); -impl Default for LayerAccessStatsInner { - fn default() -> Self { - LayerAccessStatsInner { - first_access: None, - count_by_access_kind: EnumMap::default(), - task_kind_flag: EnumSet::default(), - last_accesses: HistoryBuffer::default(), - last_residence_changes: HistoryBuffer::default(), - } - } -} - impl LayerAccessStats { pub(crate) fn for_loading_layer(residence_status: LayerResidenceStatus) -> Self { let new = LayerAccessStats(Mutex::new(LayerAccessStatsInner::default()));