From db9d78151a77acf5e70f5b30f68be328f49b36db Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Thu, 27 Apr 2023 18:46:36 +0200 Subject: [PATCH] add TODO comment regarding de-configuration of remote storage --- pageserver/src/tenant.rs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pageserver/src/tenant.rs b/pageserver/src/tenant.rs index e60567f5fa..5d46c8265c 100644 --- a/pageserver/src/tenant.rs +++ b/pageserver/src/tenant.rs @@ -1075,7 +1075,12 @@ impl Tenant { let index_part = match index_part { MaybeDeletedIndexPart::IndexPart(index_part) => index_part, MaybeDeletedIndexPart::Deleted => { - info!("is_deleted is set on remote, proceeding to remove local data"); + /// TODO: we won't reach here if remote storage gets de-configured after start of the deletion operation. + /// Example: start deletion operation, finishes upload of index part, pageserver crashes, remote storage gets de-configured, pageserver starts. + /// + /// We don't really anticipate remote storage to be de-configured, so, for now, this is fine. + /// Also, maybe we'll remove that option entirely in the future, see https://github.com/neondatabase/neon/issues/4099. + info!("is_deleted is set on remote, resuming removal of local data originally done by timeline deletion handler"); std::fs::remove_dir_all( self.conf.timeline_path(&timeline_id, &self.tenant_id), )