From dd56eeefbf1ee3cdccd1e5d4bf1ae766621b5da9 Mon Sep 17 00:00:00 2001
From: Heikki Linnakangas <heikki@zenith.tech>
Date: Thu, 10 Mar 2022 15:45:50 +0200
Subject: [PATCH] Crank up logging

---
 pageserver/src/layered_repository.rs             | 5 ++---
 pageserver/src/layered_repository/delta_layer.rs | 6 +++---
 pageserver/src/layered_repository/image_layer.rs | 2 +-
 pageserver/src/pgdatadir_mapping.rs              | 1 +
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/pageserver/src/layered_repository.rs b/pageserver/src/layered_repository.rs
index b4bdd7eff8..1de6d2b023 100644
--- a/pageserver/src/layered_repository.rs
+++ b/pageserver/src/layered_repository.rs
@@ -1069,10 +1069,9 @@ impl LayeredTimeline {
 
             // Recurse into ancestor if needed
             if Lsn(cont_lsn.0 - 1) <= timeline.ancestor_lsn {
-                trace!(
+                info!(
                     "going into ancestor {}, cont_lsn is {}",
-                    timeline.ancestor_lsn,
-                    cont_lsn
+                    timeline.ancestor_lsn, cont_lsn
                 );
                 let ancestor = timeline.get_ancestor_timeline()?;
                 timeline_owned = ancestor;
diff --git a/pageserver/src/layered_repository/delta_layer.rs b/pageserver/src/layered_repository/delta_layer.rs
index 641db7930b..1fbbb9a451 100644
--- a/pageserver/src/layered_repository/delta_layer.rs
+++ b/pageserver/src/layered_repository/delta_layer.rs
@@ -583,8 +583,6 @@ impl DeltaLayerWriter {
             }),
         };
 
-        trace!("created delta layer {}", &layer.path().display());
-
         // Rename the file to its final name
         //
         // Note: This overwrites any existing file. There shouldn't be any.
@@ -598,7 +596,9 @@ impl DeltaLayerWriter {
                 lsn_range: self.lsn_range,
             },
         );
-        std::fs::rename(self.path, final_path)?;
+        std::fs::rename(self.path, &final_path)?;
+
+        info!("created delta layer {}", final_path.display());
 
         Ok(layer)
     }
diff --git a/pageserver/src/layered_repository/image_layer.rs b/pageserver/src/layered_repository/image_layer.rs
index 2ce57e9940..23eec2e34d 100644
--- a/pageserver/src/layered_repository/image_layer.rs
+++ b/pageserver/src/layered_repository/image_layer.rs
@@ -481,7 +481,7 @@ impl ImageLayerWriter {
                 index: HashMap::new(),
             }),
         };
-        trace!("created image layer {}", layer.path().display());
+        info!("created image layer {}", layer.path().display());
 
         self.finished = true;
 
diff --git a/pageserver/src/pgdatadir_mapping.rs b/pageserver/src/pgdatadir_mapping.rs
index c44e13b11f..6b3f4d1497 100644
--- a/pageserver/src/pgdatadir_mapping.rs
+++ b/pageserver/src/pgdatadir_mapping.rs
@@ -594,6 +594,7 @@ impl<'a, R: Repository> DatadirTimelineWriter<'a, R> {
     // - update relish header with size
 
     pub fn put_rel_creation(&mut self, rel: RelTag, nblocks: BlockNumber) -> Result<()> {
+        info!("CREATE REL: {}, {} blocks at {}", rel, nblocks, self.lsn);
         // Add it to the directory entry
         let dir_key = rel_dir_to_key(rel.spcnode, rel.dbnode);
         let buf = self.get(dir_key)?;