From e2dec100ffd12f93d30a2591613df9e3ba2ce54e Mon Sep 17 00:00:00 2001
From: Anastasia Lubennikova <anastasia@neon.tech>
Date: Wed, 14 Sep 2022 18:37:33 +0300
Subject: [PATCH] code cleanup after review

---
 pageserver/src/basebackup.rs        | 5 -----
 pageserver/src/pgdatadir_mapping.rs | 3 ---
 2 files changed, 8 deletions(-)

diff --git a/pageserver/src/basebackup.rs b/pageserver/src/basebackup.rs
index 3721dda5db..d0a57a473b 100644
--- a/pageserver/src/basebackup.rs
+++ b/pageserver/src/basebackup.rs
@@ -267,8 +267,6 @@ where
             None
         };
 
-        // TODO pass this as a parameter
-
         if spcnode == GLOBALTABLESPACE_OID {
             let pg_version_str = self.timeline.pg_version.to_string();
             let header = new_tar_header("PG_VERSION", pg_version_str.len() as u64)?;
@@ -276,9 +274,6 @@ where
 
             info!("timeline.pg_version {}", self.timeline.pg_version);
 
-            let header = new_tar_header("global/PG_VERSION", pg_version_str.len() as u64)?;
-            self.ar.append(&header, pg_version_str.as_bytes())?;
-
             if let Some(img) = relmap_img {
                 // filenode map for global tablespace
                 let header = new_tar_header("global/pg_filenode.map", img.len() as u64)?;
diff --git a/pageserver/src/pgdatadir_mapping.rs b/pageserver/src/pgdatadir_mapping.rs
index 204a666b80..fc9867dc05 100644
--- a/pageserver/src/pgdatadir_mapping.rs
+++ b/pageserver/src/pgdatadir_mapping.rs
@@ -1128,9 +1128,6 @@ static ZERO_PAGE: Bytes = Bytes::from_static(&[0u8; BLCKSZ as usize]);
 //
 // Checkpoint:
 // 03 00000000 00000000 00000000 00   00000001
-//
-// PG_VERSION:
-// 03 00000000 00000000 00000000 00   00000002
 //-- Section 01: relation data and metadata
 
 const DBDIR_KEY: Key = Key {