From e3f4c0e4acf04456a714388bf2192c274e56521b Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Thu, 24 Nov 2022 10:04:02 -0500 Subject: [PATCH] remove FIXME addressed by 'On tenant load, start WAL receivers only after all timelines have been loaded.' --- pageserver/src/tenant.rs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pageserver/src/tenant.rs b/pageserver/src/tenant.rs index effd4c0249..e7512d993e 100644 --- a/pageserver/src/tenant.rs +++ b/pageserver/src/tenant.rs @@ -892,10 +892,6 @@ impl Tenant { // Sort the array of timeline IDs into tree-order, so that parent comes before // all its children. let sorted_timelines = tree_sort_timelines(timelines_to_load)?; - // FIXME if we init some of the timelines and one of them is broken we - // potentially will end up with partially launched wal receivers. - // 1. Either move it out of initialize_with_lock - // 2. Or pass it as a flag // FIXME original collect_timeline_files contained one more check: // 1. "Timeline has no ancestor and no layer files"