From e3fb145f0f042d8878cc9035bb2f29f797cb6792 Mon Sep 17 00:00:00 2001 From: Christian Schwarz Date: Sat, 27 Jan 2024 12:47:57 +0000 Subject: [PATCH] TODO/workaround: walredo quiescing broken with compaction_period=0 --- pageserver/src/tenant/tasks.rs | 2 +- .../test_pageserver_max_throughput_getpage_at_latest_lsn.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/pageserver/src/tenant/tasks.rs b/pageserver/src/tenant/tasks.rs index 5f39c46a84..6b2e81dca7 100644 --- a/pageserver/src/tenant/tasks.rs +++ b/pageserver/src/tenant/tasks.rs @@ -199,7 +199,7 @@ async fn compaction_loop(tenant: Arc, cancel: CancellationToken) { // Perhaps we did no work and the walredo process has been idle for some time: // give it a chance to shut down to avoid leaving walredo process running indefinitely. - tenant.walredo_mgr.maybe_quiesce(period * 10); + tenant.walredo_mgr.maybe_quiesce(period * 10); // TODO: broken with compaction_period 0 // Sleep if tokio::time::timeout(sleep_duration, cancel.cancelled()) diff --git a/test_runner/performance/pageserver/pagebench/test_pageserver_max_throughput_getpage_at_latest_lsn.py b/test_runner/performance/pageserver/pagebench/test_pageserver_max_throughput_getpage_at_latest_lsn.py index 1ed7e577b9..a2ffa385d9 100644 --- a/test_runner/performance/pageserver/pagebench/test_pageserver_max_throughput_getpage_at_latest_lsn.py +++ b/test_runner/performance/pageserver/pagebench/test_pageserver_max_throughput_getpage_at_latest_lsn.py @@ -76,6 +76,10 @@ def test_pageserver_max_throughput_getpage_at_latest_lsn( for param, (value, kwargs) in params.items(): record(param, metric_value=value, report=MetricReport.TEST_PARAM, **kwargs) env = setup_pageserver_with_pgbench_tenants(neon_env_builder, pg_bin, n_tenants, pgbench_scale) + ps_http =env.pageserver.http_client() + for tenant_info in ps_http.tenant_list(): + tenant_id = tenant_info["id"] + ps_http.patch_tenant_config_client_side(tenant_id, {"compaction_period": "10s"}) run_benchmark_max_throughput_latest_lsn(env, pg_bin, record, duration)