From e442f5357bd049511e72aaa7d6352c4c08159733 Mon Sep 17 00:00:00 2001 From: Dmitry Rodionov Date: Fri, 3 Jun 2022 15:21:01 +0300 Subject: [PATCH] unify two identical failpoints in flush_frozen_layer probably is a merge artfact --- pageserver/src/layered_repository.rs | 4 +--- test_runner/batch_others/test_ancestor_branch.py | 2 +- test_runner/batch_others/test_recovery.py | 3 ++- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/pageserver/src/layered_repository.rs b/pageserver/src/layered_repository.rs index 84ef2aa380..7696f0d021 100644 --- a/pageserver/src/layered_repository.rs +++ b/pageserver/src/layered_repository.rs @@ -1727,9 +1727,7 @@ impl LayeredTimeline { new_delta_path.clone(), self.conf.timeline_path(&self.timeline_id, &self.tenant_id), ])?; - fail_point!("checkpoint-before-sync"); - - fail_point!("flush-frozen"); + fail_point!("flush-frozen-before-sync"); // Finally, replace the frozen in-memory layer with the new on-disk layer { diff --git a/test_runner/batch_others/test_ancestor_branch.py b/test_runner/batch_others/test_ancestor_branch.py index 3a16157093..656428e5df 100644 --- a/test_runner/batch_others/test_ancestor_branch.py +++ b/test_runner/batch_others/test_ancestor_branch.py @@ -24,7 +24,7 @@ def test_ancestor_branch(neon_env_builder: NeonEnvBuilder): 'compaction_target_size': '4194304', }) - env.pageserver.safe_psql("failpoints flush-frozen=sleep(10000)") + env.pageserver.safe_psql("failpoints flush-frozen-before-sync=sleep(10000)") pg_branch0 = env.postgres.create_start('main', tenant_id=tenant) branch0_cur = pg_branch0.connect().cursor() diff --git a/test_runner/batch_others/test_recovery.py b/test_runner/batch_others/test_recovery.py index 14d1adf25d..5ba783b802 100644 --- a/test_runner/batch_others/test_recovery.py +++ b/test_runner/batch_others/test_recovery.py @@ -45,7 +45,8 @@ def test_pageserver_recovery(neon_env_builder: NeonEnvBuilder): # Configure failpoints pscur.execute( - "failpoints checkpoint-before-sync=sleep(2000);checkpoint-after-sync=exit") + "failpoints flush-frozen-before-sync=sleep(2000);checkpoint-after-sync=exit" + ) # Do some updates until pageserver is crashed try: