From e48a8415fff613312d67110426306c87bcb93dbd Mon Sep 17 00:00:00 2001 From: Konstantin Knizhnik Date: Wed, 9 Oct 2024 18:29:37 +0300 Subject: [PATCH] Add comments --- pageserver/src/aux_file.rs | 1 + pageserver/src/basebackup.rs | 2 ++ 2 files changed, 3 insertions(+) diff --git a/pageserver/src/aux_file.rs b/pageserver/src/aux_file.rs index c3ddca3c3d..9f1bbea8c9 100644 --- a/pageserver/src/aux_file.rs +++ b/pageserver/src/aux_file.rs @@ -54,6 +54,7 @@ const AUX_DIR_PG_UNKNOWN: u8 = 0xFF; /// * pg_logical/replorigin_checkpoint -> 0x0103 /// * pg_logical/others -> 0x01FF /// * pg_replslot/ -> 0x0201 +/// * pg_stat/pgstat.stat -> 0x0301 /// * others -> 0xFFFF /// /// If you add new AUX files to this function, please also add a test case to `test_encoding_portable`. diff --git a/pageserver/src/basebackup.rs b/pageserver/src/basebackup.rs index 9315330737..50e48593d6 100644 --- a/pageserver/src/basebackup.rs +++ b/pageserver/src/basebackup.rs @@ -258,6 +258,8 @@ where async fn send_tarball(mut self) -> Result<(), BasebackupError> { // TODO include checksum + // On normal Postgres shutdown, shutdown checkpoint should be performed and correspondent + // WAL record should be the last record in the WAL. let normal_shutdown = if let Ok(checkpoint_bytes) = self.timeline.get_checkpoint(self.lsn, self.ctx).await {