From e675f4cec85b9341448230af72ef732fb0dae02e Mon Sep 17 00:00:00 2001 From: John Spray Date: Mon, 30 Oct 2023 15:18:32 +0000 Subject: [PATCH] =?UTF-8?q?tests:=20fix=20missing=20comma=20=20in=20test?= =?UTF-8?q?=5Ftimeline=5Fdeletion=5Fwith=5Ffiles=5Fstuck=5F=E2=80=A6=20(#5?= =?UTF-8?q?713)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …in_upload_queue This was a syntax mistake in https://github.com/neondatabase/neon/pull/5149 We didn't notice because the situation the log allow list covers is a relative rare race. --- test_runner/regress/test_remote_storage.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test_runner/regress/test_remote_storage.py b/test_runner/regress/test_remote_storage.py index f201c735e1..31bc97703e 100644 --- a/test_runner/regress/test_remote_storage.py +++ b/test_runner/regress/test_remote_storage.py @@ -585,9 +585,11 @@ def test_timeline_deletion_with_files_stuck_in_upload_queue( # checkpoint operations. Hence, checkpoint is allowed to fail now. log.info("sending delete request") checkpoint_allowed_to_fail.set() - env.pageserver.allowed_errors.append( - ".* ERROR .*Error processing HTTP request: InternalServerError\\(The timeline or pageserver is shutting down" - ".* ERROR .*[Cc]ould not flush frozen layer.*" + env.pageserver.allowed_errors.extend( + [ + ".* ERROR .*Error processing HTTP request: InternalServerError\\(The timeline or pageserver is shutting down", + ".* ERROR .*[Cc]ould not flush frozen layer.*", + ] ) # Generous timeout, because currently deletions can get blocked waiting for compaction