From e7005c61b8b6b830f9aed84eda2d8c2af5911d54 Mon Sep 17 00:00:00 2001 From: John Spray Date: Tue, 10 Oct 2023 09:49:42 +0100 Subject: [PATCH] pageserver: remove 3 day timeout workaround --- pageserver/src/page_service.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pageserver/src/page_service.rs b/pageserver/src/page_service.rs index 5ab4fbbd4c..b16cdd202e 100644 --- a/pageserver/src/page_service.rs +++ b/pageserver/src/page_service.rs @@ -213,9 +213,9 @@ async fn page_service_conn_main( // no write timeout is used, because the kernel is assumed to error writes after some time. let mut socket = tokio_io_timeout::TimeoutReader::new(socket); - // timeout should be lower, but trying out multiple days for - // - socket.set_timeout(Some(std::time::Duration::from_secs(60 * 60 * 24 * 3))); + // A timeout here does not mean the client died, it can happen if it's just idle for + // a while: we will tear down this PageServerHandler and instantiate a new one if/when they reconnect. + socket.set_timeout(Some(std::time::Duration::from_secs(60 * 10))); let socket = std::pin::pin!(socket); // XXX: pgbackend.run() should take the connection_ctx,