From eb3711b88156019908d99f3e08393f4c8a04f8b0 Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Fri, 26 Jul 2024 08:18:17 +0000 Subject: [PATCH] doc: why no cancel --- pageserver/src/tenant/timeline/detach_ancestor.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pageserver/src/tenant/timeline/detach_ancestor.rs b/pageserver/src/tenant/timeline/detach_ancestor.rs index b3c078312e..4fd6e054b2 100644 --- a/pageserver/src/tenant/timeline/detach_ancestor.rs +++ b/pageserver/src/tenant/timeline/detach_ancestor.rs @@ -302,6 +302,8 @@ impl SharedState { .get(&attempt.timeline_id) .cloned() else { + // no need to cancel the attempt, because timeline deletion and/or tenant restart has + // already marked it unblocked. return Err(Error::DetachedNotFoundAfterRestart); };