From ebf44210ba2fdd66de25f2689182dcb1c4a6d3f7 Mon Sep 17 00:00:00 2001 From: John Spray Date: Mon, 27 Jan 2025 17:44:18 +0000 Subject: [PATCH] remote_storage: less sensitive timeout logging in ABS listings (#10518) ## Problem We were logging a warning after a single request timeout, while listing objects. Closes: https://github.com/neondatabase/neon/issues/10166 ## Summary of changes - These timeouts are a pretty normal part of life, so back it off to only log a warning after two in a row. --- libs/remote_storage/src/azure_blob.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libs/remote_storage/src/azure_blob.rs b/libs/remote_storage/src/azure_blob.rs index c89f50ef2b..9027a8bf55 100644 --- a/libs/remote_storage/src/azure_blob.rs +++ b/libs/remote_storage/src/azure_blob.rs @@ -377,7 +377,8 @@ impl RemoteStorage for AzureBlobStorage { let next_item = next_item?; - if timeout_try_cnt >= 2 { + // Log a warning if we saw two timeouts in a row before a successful request + if timeout_try_cnt > 2 { tracing::warn!("Azure Blob Storage list timed out and succeeded after {} tries", timeout_try_cnt); } timeout_try_cnt = 1;