From ecf759be6d40cc755892f569ea9d146d0a6db25b Mon Sep 17 00:00:00 2001 From: John Spray Date: Wed, 18 Oct 2023 16:16:58 +0100 Subject: [PATCH] tests: allow-list S3 500 on DeleteObjects key (#5586) ## Problem S3 can give us a 500 whenever it likes: when this happens at request level we eat it in `backoff::retry`, but when it happens for a key inside a DeleteObjects request, we log it at warn level. ## Summary of changes Allow-list this class of log message in all tests. --- test_runner/fixtures/neon_fixtures.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test_runner/fixtures/neon_fixtures.py b/test_runner/fixtures/neon_fixtures.py index 68e29523b0..a9fe5e376e 100644 --- a/test_runner/fixtures/neon_fixtures.py +++ b/test_runner/fixtures/neon_fixtures.py @@ -1632,6 +1632,9 @@ class NeonPageserver(PgProtocol): # these can happen during shutdown, but it should not be a reason to fail a test ".*completed, took longer than expected.*", '.*registered custom resource manager "neon".*', + # AWS S3 may emit 500 errors for keys in a DeleteObjects response: we retry these + # and it is not a failure of our code when it happens. + ".*DeleteObjects.*We encountered an internal error. Please try again.*", ] def timeline_dir(self, tenant_id: TenantId, timeline_id: Optional[TimelineId] = None) -> Path: