From ee87e6aad3f00ababea705a6c150e4825e7548f3 Mon Sep 17 00:00:00 2001
From: Konstantin Knizhnik <knizhnik@garret.ru>
Date: Thu, 22 Apr 2021 22:14:41 +0300
Subject: [PATCH] Sum log files in case of test failure

---
 control_plane/src/compute.rs  | 20 ++++++++++++++++++--
 pageserver/src/page_cache.rs  | 16 ++++++++++------
 pageserver/src/walreceiver.rs |  2 +-
 3 files changed, 29 insertions(+), 9 deletions(-)

diff --git a/control_plane/src/compute.rs b/control_plane/src/compute.rs
index fe2204b539..6af7427294 100644
--- a/control_plane/src/compute.rs
+++ b/control_plane/src/compute.rs
@@ -1,4 +1,4 @@
-use std::fs::{self, OpenOptions};
+use std::fs::{self, File, OpenOptions};
 use std::io::{Read, Write};
 use std::net::SocketAddr;
 use std::net::TcpStream;
@@ -399,6 +399,18 @@ impl PostgresNode {
         String::from_utf8(output.stdout).unwrap().trim().to_string()
     }
 
+    fn dump_log_files(&self) {
+        let dir = zenith_repo_dir();
+        for entry in fs::read_dir(dir).unwrap() {
+            let entry = entry.unwrap();
+            let path = entry.path();
+            let mut file = File::open(&path).unwrap();
+            let mut buffer = String::new();
+            file.read_to_string(&mut buffer).unwrap();
+            println!("File {:?}:\n{}", &path, buffer);
+        }
+    }
+
     pub fn safe_psql(&self, db: &str, sql: &str) -> Vec<tokio_postgres::Row> {
         let connstring = format!(
             "host={} port={} dbname={} user={}",
@@ -410,7 +422,11 @@ impl PostgresNode {
         let mut client = Client::connect(connstring.as_str(), NoTls).unwrap();
 
         println!("Running {}", sql);
-        client.query(sql, &[]).unwrap()
+        let result = client.query(sql, &[]);
+        if result.is_err() {
+            self.dump_log_files();
+        }
+        result.unwrap()
     }
 
     pub fn open_psql(&self, db: &str) -> Client {
diff --git a/pageserver/src/page_cache.rs b/pageserver/src/page_cache.rs
index 0a9eca57b3..54d4ca63fd 100644
--- a/pageserver/src/page_cache.rs
+++ b/pageserver/src/page_cache.rs
@@ -172,7 +172,7 @@ fn open_rocksdb(_conf: &PageServerConf, timelineid: ZTimelineId) -> rocksdb::DB
     opts.create_if_missing(true);
     opts.set_use_fsync(true);
     opts.set_compression_type(rocksdb::DBCompressionType::Lz4);
-	opts.create_missing_column_families(true);
+    opts.create_missing_column_families(true);
     rocksdb::DB::open_cf(&opts, &path, &[rocksdb::DEFAULT_COLUMN_FAMILY_NAME]).unwrap()
 }
 
@@ -429,7 +429,7 @@ impl PageCache {
 
                         // reconstruct most recent page version
                         if content.wal_record.is_some() {
-							trace!("Reconstruct most recent page {:?}", key);
+                            trace!("Reconstruct most recent page {:?}", key);
                             // force reconstruction of most recent page version
                             self.reconstruct_page(key, content)?;
                         }
@@ -451,7 +451,7 @@ impl PageCache {
                                     minbuf.clear();
                                     minbuf.extend_from_slice(&k);
                                     let key = CacheKey::unpack(&mut minbuf);
-									trace!("Reconstruct horizon page {:?}", key);
+                                    trace!("Reconstruct horizon page {:?}", key);
                                     self.reconstruct_page(key, content)?;
                                 }
                             }
@@ -459,13 +459,13 @@ impl PageCache {
                         // remove records prior to horizon
                         minbuf.clear();
                         minkey.pack(&mut minbuf);
-						trace!("Delete records in range {:?}..{:?}", minkey, maxkey);
+                        trace!("Delete records in range {:?}..{:?}", minkey, maxkey);
                         self.db.delete_range_cf(cf, &minbuf[..], &maxbuf[..])?;
 
                         maxkey = minkey;
                     } else {
-						break;
-					}
+                        break;
+                    }
                 }
             }
         }
@@ -857,11 +857,13 @@ impl PageCache {
                         }
                     }
                     let relsize = tag.blknum + 1;
+                    info!("Size of relation {:?} at {} is {}", rel, lsn, relsize);
                     return Ok(relsize);
                 }
             }
             break;
         }
+        info!("Size of relation {:?} at {} is zero", rel, lsn);
         Ok(0)
     }
 
@@ -886,9 +888,11 @@ impl PageCache {
             buf.extend_from_slice(&k);
             let tag = BufferTag::unpack(&mut buf);
             if tag.rel == *rel {
+                info!("Relation {:?} exists at {}", rel, lsn);
                 return Ok(true);
             }
         }
+        info!("Relation {:?} doesn't exist at {}", rel, lsn);
         Ok(false)
     }
 
diff --git a/pageserver/src/walreceiver.rs b/pageserver/src/walreceiver.rs
index ba517b2138..a70fbb9c02 100644
--- a/pageserver/src/walreceiver.rs
+++ b/pageserver/src/walreceiver.rs
@@ -15,6 +15,7 @@ use crate::ZTimelineId;
 use anyhow::Error;
 use lazy_static::lazy_static;
 use log::*;
+use postgres_ffi::xlog_utils::*;
 use postgres_protocol::message::backend::ReplicationMessage;
 use postgres_types::PgLsn;
 use std::collections::HashMap;
@@ -30,7 +31,6 @@ use tokio::time::{sleep, Duration};
 use tokio_postgres::replication::{PgTimestamp, ReplicationStream};
 use tokio_postgres::{NoTls, SimpleQueryMessage, SimpleQueryRow};
 use tokio_stream::StreamExt;
-use postgres_ffi::xlog_utils::*;
 
 //
 // We keep one WAL Receiver active per timeline.