From f669e184771cfd44d84075fbb191bb1eabbfca3c Mon Sep 17 00:00:00 2001 From: Tristan Partin Date: Mon, 16 Jun 2025 14:38:26 -0500 Subject: [PATCH] Remove TODO comment related to default_transaction_read_only (#12261) This code has been deployed for a while, so let's remove the TODO, and remove the option passed from the control plane. Link: https://github.com/neondatabase/cloud/pull/30274 Signed-off-by: Tristan Partin --- compute_tools/src/compute.rs | 5 ----- 1 file changed, 5 deletions(-) diff --git a/compute_tools/src/compute.rs b/compute_tools/src/compute.rs index f15538b157..50c254224a 100644 --- a/compute_tools/src/compute.rs +++ b/compute_tools/src/compute.rs @@ -354,11 +354,6 @@ impl ComputeNode { // that can affect `compute_ctl` and prevent it from properly configuring the database schema. // Unset them via connection string options before connecting to the database. // N.B. keep it in sync with `ZENITH_OPTIONS` in `get_maintenance_client()`. - // - // TODO(ololobus): we currently pass `-c default_transaction_read_only=off` from control plane - // as well. After rolling out this code, we can remove this parameter from control plane. - // In the meantime, double-passing is fine, the last value is applied. - // See: const EXTRA_OPTIONS: &str = "-c role=cloud_admin -c default_transaction_read_only=off -c search_path=public -c statement_timeout=0"; let options = match conn_conf.get_options() { Some(options) => format!("{} {}", options, EXTRA_OPTIONS),