diff --git a/pageserver/src/tenant/layer_map.rs b/pageserver/src/tenant/layer_map.rs index 0751e44f1c..2e3cfaab9a 100644 --- a/pageserver/src/tenant/layer_map.rs +++ b/pageserver/src/tenant/layer_map.rs @@ -727,7 +727,7 @@ mod tests { // and can remove it in the future. let _map = LayerMap::default(); - let mut mapping = TestLayerFileManager::new(); + let mapping = TestLayerFileManager::new(); mapping .replace_and_verify(not_found, new_version) @@ -742,7 +742,7 @@ mod tests { let downloaded = Arc::new(LayerObject::new(skeleton)); let mut map = LayerMap::default(); - let mut mapping = LayerFileManager::new(); + let mapping = LayerFileManager::new(); // two disjoint Arcs in different lifecycle phases. even if it seems they must be the // same layer, we use LayerMap::compare_arced_layers as the identity of layers. diff --git a/pageserver/src/tenant/timeline.rs b/pageserver/src/tenant/timeline.rs index f1d9e14ad5..31e8cd3785 100644 --- a/pageserver/src/tenant/timeline.rs +++ b/pageserver/src/tenant/timeline.rs @@ -2602,7 +2602,9 @@ impl Timeline { Some(self.write_lock.lock().await) }; let mut guard = self.layers.write().await; - guard.try_freeze_in_memory_layer(self.get_last_record_lsn(), &self.last_freeze_at).await; + guard + .try_freeze_in_memory_layer(self.get_last_record_lsn(), &self.last_freeze_at) + .await; } /// Layer flusher task's main loop. @@ -2774,7 +2776,9 @@ impl Timeline { self.metrics.persistent_bytes_written.inc_by(sz); } - guard.finish_flush_l0_layer(delta_layer_to_add, &frozen_layer).await; + guard + .finish_flush_l0_layer(delta_layer_to_add, &frozen_layer) + .await; // release lock on 'layers' } diff --git a/pageserver/src/tenant/timeline/layer_manager.rs b/pageserver/src/tenant/timeline/layer_manager.rs index 4abc79e51a..375455ca01 100644 --- a/pageserver/src/tenant/timeline/layer_manager.rs +++ b/pageserver/src/tenant/timeline/layer_manager.rs @@ -509,7 +509,7 @@ pub struct LayerFileManager( ); impl LayerFileManager { - fn get_from_desc(&self, desc: &PersistentLayerDesc) -> Arc { + pub(crate) fn get_from_desc(&self, desc: &PersistentLayerDesc) -> Arc { // The assumption for the `expect()` is that all code maintains the following invariant: // A layer's descriptor is present in the LayerMap => the LayerFileManager contains a layer for the descriptor. self.0 @@ -519,22 +519,22 @@ impl LayerFileManager { .clone() } - fn insert(&self, layer: Arc) { + pub(crate) fn insert(&self, layer: Arc) { let present = self.0.insert(layer.layer_desc().key(), layer.clone()); if present.is_some() && cfg!(debug_assertions) { panic!("overwriting a layer: {:?}", layer.layer_desc()) } } - fn contains(&self, layer: &Arc) -> bool { + pub(crate) fn contains(&self, layer: &Arc) -> bool { self.0.contains_key(&layer.layer_desc().key()) } - fn new() -> Self { + pub(crate) fn new() -> Self { Self(DashMap::new()) } - fn remove(&self, layer: Arc) { + pub(crate) fn remove(&self, layer: Arc) { let present = self.0.remove(&layer.layer_desc().key()); if present.is_none() && cfg!(debug_assertions) { panic!( @@ -544,7 +544,7 @@ impl LayerFileManager { } } - fn replace_and_verify(&self, expected: Arc, new: Arc) -> Result<()> { + pub(crate) fn replace_and_verify(&self, expected: Arc, new: Arc) -> Result<()> { let key = expected.layer_desc().key(); let other = new.layer_desc().key();