From f7b0beb1cfd220ff5f85de9896c817ac125c7d53 Mon Sep 17 00:00:00 2001 From: Joonas Koivunen Date: Wed, 10 May 2023 16:27:08 +0300 Subject: [PATCH] refactor: simplify, racy removes no longer intended --- pageserver/src/tenant.rs | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/pageserver/src/tenant.rs b/pageserver/src/tenant.rs index 69450d193d..80f0310fba 100644 --- a/pageserver/src/tenant.rs +++ b/pageserver/src/tenant.rs @@ -1592,26 +1592,11 @@ impl Tenant { })); match removed_timeline { - Ok(None) => { - // This can legitimately happen if there's a concurrent call to this function. - // T1 T2 - // lock - // unlock - // lock - // unlock - // remove files - // lock - // remove from map - // unlock - // return - // remove files - // lock - // remove from map observes empty map - // unlock - // return - debug!("concurrent call to this function won the race"); - } Ok(Some(_)) => {} + Ok(None) => { + // with SharedRetryable this should no longer happen + warn!("no other task should had dropped the Timeline"); + } Err(_panic) => return Err(InnerDeleteTimelineError::DeletedGrewChildren), }