From fec5ac5838cbd5664b838cec8f0166e36380297c Mon Sep 17 00:00:00 2001 From: John Spray Date: Fri, 17 Jan 2025 09:54:05 +0000 Subject: [PATCH] storage controller: a more comprehensive log on tenant creation --- storage_controller/src/service.rs | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/storage_controller/src/service.rs b/storage_controller/src/service.rs index 9ac9ee17ca..f41b0d0c39 100644 --- a/storage_controller/src/service.rs +++ b/storage_controller/src/service.rs @@ -2109,12 +2109,6 @@ impl Service { create_req.new_tenant_id.tenant_id }; - tracing::info!( - "Creating tenant {}, shard_count={:?}", - create_req.new_tenant_id, - create_req.shard_parameters.count, - ); - let create_ids = (0..create_req.shard_parameters.count.count()) .map(|i| TenantShardId { tenant_id, @@ -2155,6 +2149,14 @@ impl Service { } }; + tracing::info!( + generation=?initial_generation, + preferred_az_id=?preferred_az_id, + tenant_id=%create_req.new_tenant_id, + shard_count=?create_req.shard_parameters.count, + "Creating tenant", + ); + // Ordering: we persist tenant shards before creating them on the pageserver. This enables a caller // to clean up after themselves by issuing a tenant deletion if something goes wrong and we restart // during the creation, rather than risking leaving orphan objects in S3.