mirror of
https://github.com/neondatabase/neon.git
synced 2026-01-15 17:32:56 +00:00
ed938885ff
If database was created with `is_template true` Postgres doesn't allow dropping it right away and throws error ``` ERROR: cannot drop a template database ``` so we have to unset `is_template` first. Fixing it, I noticed that our `escape_literal` isn't exactly correct and following the same logic as in `quote_literal_internal`, we need to prepend string with `E`. Otherwise, it's not possible to filter `pg_database` using `escape_literal()` result if name contains `\`, for example. Also use `FORCE` to drop database even if there are active connections. We run this from `cloud_admin`, so it should have enough privileges. NB: there could be other db states, which prevent us from dropping the database. For example, if db is used by any active subscription or logical replication slot. TODO: deal with it once we allow logical replication. Proper fix should involve returning an error code to the control plane, so it could figure out that this is a non-retryable error, return it to the user and mark operation as permanently failed. Related to neondatabase/cloud#4258
101 lines
3.4 KiB
Rust
101 lines
3.4 KiB
Rust
#[cfg(test)]
|
|
mod pg_helpers_tests {
|
|
use std::fs::File;
|
|
|
|
use compute_api::spec::{ComputeSpec, GenericOption, GenericOptions, PgIdent};
|
|
use compute_tools::pg_helpers::*;
|
|
|
|
#[test]
|
|
fn params_serialize() {
|
|
let file = File::open("../libs/compute_api/tests/cluster_spec.json").unwrap();
|
|
let spec: ComputeSpec = serde_json::from_reader(file).unwrap();
|
|
|
|
assert_eq!(
|
|
spec.cluster.databases.first().unwrap().to_pg_options(),
|
|
"LC_COLLATE 'C' LC_CTYPE 'C' TEMPLATE template0 OWNER \"alexk\""
|
|
);
|
|
assert_eq!(
|
|
spec.cluster.roles.first().unwrap().to_pg_options(),
|
|
" LOGIN PASSWORD 'md56b1d16b78004bbd51fa06af9eda75972'"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn settings_serialize() {
|
|
let file = File::open("../libs/compute_api/tests/cluster_spec.json").unwrap();
|
|
let spec: ComputeSpec = serde_json::from_reader(file).unwrap();
|
|
|
|
assert_eq!(
|
|
spec.cluster.settings.as_pg_settings(),
|
|
r#"fsync = off
|
|
wal_level = replica
|
|
hot_standby = on
|
|
neon.safekeepers = '127.0.0.1:6502,127.0.0.1:6503,127.0.0.1:6501'
|
|
wal_log_hints = on
|
|
log_connections = on
|
|
shared_buffers = 32768
|
|
port = 55432
|
|
max_connections = 100
|
|
max_wal_senders = 10
|
|
listen_addresses = '0.0.0.0'
|
|
wal_sender_timeout = 0
|
|
password_encryption = md5
|
|
maintenance_work_mem = 65536
|
|
max_parallel_workers = 8
|
|
max_worker_processes = 8
|
|
neon.tenant_id = 'b0554b632bd4d547a63b86c3630317e8'
|
|
max_replication_slots = 10
|
|
neon.timeline_id = '2414a61ffc94e428f14b5758fe308e13'
|
|
shared_preload_libraries = 'neon'
|
|
synchronous_standby_names = 'walproposer'
|
|
neon.pageserver_connstring = 'host=127.0.0.1 port=6400'
|
|
test.escaping = 'here''s a backslash \\ and a quote '' and a double-quote " hooray'
|
|
"#
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn ident_pg_quote() {
|
|
let ident: PgIdent = PgIdent::from("\"name\";\\n select 1;");
|
|
|
|
assert_eq!(ident.pg_quote(), "\"\"\"name\"\";\\n select 1;\"");
|
|
}
|
|
|
|
#[test]
|
|
fn generic_options_search() {
|
|
let generic_options: GenericOptions = Some(vec![
|
|
GenericOption {
|
|
name: "present_value".into(),
|
|
value: Some("value".into()),
|
|
vartype: "string".into(),
|
|
},
|
|
GenericOption {
|
|
name: "missed_value".into(),
|
|
value: None,
|
|
vartype: "int".into(),
|
|
},
|
|
]);
|
|
assert_eq!(generic_options.find("present_value"), Some("value".into()));
|
|
assert_eq!(generic_options.find("missed_value"), None);
|
|
assert_eq!(generic_options.find("invalid_value"), None);
|
|
|
|
let empty_generic_options: GenericOptions = Some(vec![]);
|
|
assert_eq!(empty_generic_options.find("present_value"), None);
|
|
assert_eq!(empty_generic_options.find("missed_value"), None);
|
|
assert_eq!(empty_generic_options.find("invalid_value"), None);
|
|
|
|
let none_generic_options: GenericOptions = None;
|
|
assert_eq!(none_generic_options.find("present_value"), None);
|
|
assert_eq!(none_generic_options.find("missed_value"), None);
|
|
assert_eq!(none_generic_options.find("invalid_value"), None);
|
|
}
|
|
|
|
#[test]
|
|
fn test_escape_literal() {
|
|
assert_eq!(escape_literal("test"), "'test'");
|
|
assert_eq!(escape_literal("test'"), "'test'''");
|
|
assert_eq!(escape_literal("test\\'"), "E'test\\\\'''");
|
|
assert_eq!(escape_literal("test\\'\\'"), "E'test\\\\''\\\\'''");
|
|
}
|
|
}
|