mirror of
https://github.com/neondatabase/neon.git
synced 2026-01-05 04:22:56 +00:00
This patch aims to:
* Unify connection & querying logic of ZenithPagerserver and Postgres.
* Mitigate changes to transaction machinery introduced in `psycopg2 >= 2.9`.
Now it's possible to acquire db connection using the corresponding
method:
```python
pg = postgres.create_start('main')
conn = pg.connect()
...
conn.close()
```
This pattern can be further improved with the help of `closing`:
```python
from contextlib import closing
pg = postgres.create_start('main')
with closing(pg.connect()) as conn:
...
```
All connections produced by this method will have autocommit
enabled by default.
33 lines
994 B
Python
33 lines
994 B
Python
from contextlib import closing
|
|
|
|
pytest_plugins = ("fixtures.zenith_fixtures")
|
|
|
|
|
|
#
|
|
# Test CREATE DATABASE when there have been relmapper changes
|
|
#
|
|
def test_createdb(zenith_cli, pageserver, postgres, pg_bin):
|
|
zenith_cli.run(["branch", "test_createdb", "empty"])
|
|
|
|
pg = postgres.create_start('test_createdb')
|
|
print("postgres is running on 'test_createdb' branch")
|
|
|
|
with closing(pg.connect()) as conn:
|
|
with conn.cursor() as cur:
|
|
# Cause a 'relmapper' change in the original branch
|
|
cur.execute('VACUUM FULL pg_class')
|
|
|
|
cur.execute('CREATE DATABASE foodb')
|
|
|
|
cur.execute('SELECT pg_current_wal_insert_lsn()')
|
|
lsn = cur.fetchone()[0]
|
|
|
|
# Create a branch
|
|
zenith_cli.run(["branch", "test_createdb2", "test_createdb@" + lsn])
|
|
|
|
pg2 = postgres.create_start('test_createdb2')
|
|
|
|
# Test that you can connect to the new database on both branches
|
|
for db in (pg, pg2):
|
|
db.connect(dbname='foodb').close()
|