Arseny Sher 31a3910fd9 Remove wait_for_sk_commit_lsn_to_reach_remote_storage. ...

It had a couple of inherent races:

1) Even if compute is killed before the call, some more data might still arrive
to safekeepers after commit_lsn on them is polled, advancing it. Then checkpoint
on pageserver might not include this tail, and so upload of expected LSN won't
happen until one more checkpoint.

2) commit_lsn is updated asynchronously -- compute can commit transaction before
communicating commit_lsn to even single safekeeper (sync-safekeepers can be used
to forces the advancement). This makes semantics of
wait_for_sk_commit_lsn_to_reach_remote_storage quite complicated.

Replace it with last_flush_lsn_upload which
1) Learns last flush LSN on compute;
2) Waits for it to arrive to pageserver;
3) Checkpoints it;
4) Waits for the upload.

In some tests this keeps compute alive longer than before, but this doesn't seem
to be important.

There is a chance this fixes https://github.com/neondatabase/neon/issues/3209

2023-04-26 13:46:33 +04:00

..

__init__.py

tests: make neon_fixtures a bit thinner by splitting out some pageserver related helpers (#3977)

2023-04-07 13:47:28 +03:00

http.py

add libmetric metric for each logged log message (#4055)

2023-04-25 14:10:18 +02:00

utils.py

Remove wait_for_sk_commit_lsn_to_reach_remote_storage.

2023-04-26 13:46:33 +04:00