mirror of
https://github.com/neondatabase/neon.git
synced 2026-01-07 21:42:56 +00:00
78a7f68902
## Problem All tests have already been parametrised by Postgres version and build type (to have them distinguishable in the Allure report), but despite it, it's anyway required to have DEFAULT_PG_VERSION and BUILD_TYPE env vars set to corresponding values, for example to run`test_timeline_deletion_with_files_stuck_in_upload_queue[release-pg14-local_fs]` test it's required to set `DEFAULT_PG_VERSION=14` and `BUILD_TYPE=release`. This PR makes the test framework pick up parameters from the test name itself. ## Summary of changes - Postgres version and build type related fixtures now are function-scoped (instead of being sessions scoped before) - Deprecate `--pg-version` argument in favour of DEFAULT_PG_VERSION env variable (it's easier to parse) - GitHub autocomment now includes only one command with all the failed tests + runs them in parallel
51 lines
1.6 KiB
Python
51 lines
1.6 KiB
Python
import os
|
|
from typing import Optional
|
|
|
|
import pytest
|
|
from _pytest.fixtures import FixtureRequest
|
|
from _pytest.python import Metafunc
|
|
|
|
from fixtures.pg_version import PgVersion
|
|
|
|
"""
|
|
Dynamically parametrize tests by Postgres version and build type (debug/release/remote)
|
|
"""
|
|
|
|
|
|
@pytest.fixture(scope="function", autouse=True)
|
|
def pg_version(request: FixtureRequest) -> Optional[PgVersion]:
|
|
# Do not parametrize performance tests yet, we need to prepare grafana charts first
|
|
if "test_runner/performance" in str(request.node.path):
|
|
v = os.environ.get("DEFAULT_PG_VERSION")
|
|
return PgVersion(v)
|
|
|
|
return None
|
|
|
|
|
|
@pytest.fixture(scope="function", autouse=True)
|
|
def build_type(request: FixtureRequest) -> Optional[str]:
|
|
# Do not parametrize performance tests yet, we need to prepare grafana charts first
|
|
if "test_runner/performance" in str(request.node.path):
|
|
return os.environ.get("BUILD_TYPE", "").lower()
|
|
|
|
return None
|
|
|
|
|
|
def pytest_generate_tests(metafunc: Metafunc):
|
|
# Do not parametrize performance tests yet, we need to prepare grafana charts first
|
|
if "test_runner/performance" in metafunc.definition._nodeid:
|
|
return
|
|
|
|
if (v := os.environ.get("DEFAULT_PG_VERSION")) is None:
|
|
pg_versions = [version for version in PgVersion if version != PgVersion.NOT_SET]
|
|
else:
|
|
pg_versions = [PgVersion(v)]
|
|
|
|
if (bt := os.environ.get("BUILD_TYPE")) is None:
|
|
build_types = ["debug", "release"]
|
|
else:
|
|
build_types = [bt.lower()]
|
|
|
|
metafunc.parametrize("build_type", build_types)
|
|
metafunc.parametrize("pg_version", pg_versions, ids=map(lambda v: f"pg{v}", pg_versions))
|