Christian Schwarz 7db018e147 [4/4] the fix: do not leak spawn_blocking() tasks from logical size calculation code ...

- Refactor logical_size_calculation_task, moving the pieces that are
  specific to try_spawn_size_init_task into that function.
  This allows us to spawn additional size calculation tasks that are not
  init size calculation tasks.

  - As part of this refactoring, stop logging cancellations as errors.
    They are part of regular operations.
    Logging them as errors was inadvertently introduced in earlier commit

      427c1b2e9661161439e65aabc173d695cfc03ab4
      initial logical size calculation: if it fails, retry on next call

- Change tenant size model request code to spawn task_mgr tasks using
  the refactored logical_size_calculation_task function.
  Using a task_mgr task ensures that the calculation cannot outlive
  the timeline.
  - There are presumably still some subtle race conditions if a size
    requests comes in at exactly the same time as a detach / delete
    request.
  - But that's the concern of diferent area of the code (e.g., tenant_mgr)
    and requires holistic solutions, such as the proposed TenantGuard.

- Make size calculation cancellable using CancellationToken.
  This is more of a cherry on top.
  NB: the test code doesn't use this because we _must_ return from
  the failpoint, because the failpoint lib doesn't allow to just
  continue execution in combination with executing the closure.

This commit fixes the tests introduced earlier in this patch series.

2022-12-19 16:14:58 +01:00

..

benches

refactor: use new type LayerFileName when referring to layer file names in PathBuf/RemotePath (#3026)

2022-12-13 01:27:59 +02:00

src

[4/4] the fix: do not leak spawn_blocking() tasks from logical size calculation code

2022-12-19 16:14:58 +01:00

Cargo.toml

Update rust-postgres everywhere

2022-12-17 00:26:10 +03:00