Christian Schwarz c3a470a29b walredo process management: handle every error on the kill() and drop path ...

If we're not calling kill() before dropping the PostgresRedoProcess, we
currently leak it.
That's most likely the root cause for #2761.
This patch
1. adds an error log message for that case and
2. adds error handling for all errors on the kill() path. If we're a
`testing` build, we panic. Otherwise, we log an error and leak the
process.

The error handling changes (2) are necessary to conclusively state that
the root cause for #2761 is indeed (1). If we didn't have them, the root
cause could be missing error handling instead.

To make the log messages useful, I've added tracing::instrument
attributes that log the tenant_id and PID. That helps mapping back the
PID of `defunct` processes to pageserver log messages. Note that a
defunct process's `/proc/$PID/` directory isn't very useful. We have
left little more than its PID.

Once we have validated the root cause, we'll find a fix, but that's
still an ongoing discussion.

refs https://github.com/neondatabase/neon/issues/2761
closes https://github.com/neondatabase/neon/pull/2769

2022-11-08 14:03:13 +01:00

..

benches

Add micro-benchmark for layer map search function

2022-10-18 15:00:10 +03:00

src

walredo process management: handle every error on the kill() and drop path

2022-11-08 14:03:13 +01:00

Cargo.toml

Move pq_proto to its own crate

2022-11-03 22:56:04 +03:00